-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modularise Spring AI Spring Boot autoconfigurations #2289
base: main
Are you sure you want to change the base?
Modularise Spring AI Spring Boot autoconfigurations #2289
Conversation
8818ea8
to
9895b6d
Compare
This modularisation track will be really beneficial, thank you! Is the split between For the sake of simplicity, I would consider moving the autconfiguration to the existing starter modules. So, for example, the Weaviate auto configuration would be placed in the |
There is a really good reason to keep it separate, but I’m embarrassed to say I can’t remember the argument presented to me. I think it along the lines keeping it separate is a better separation of concerns, I shouldn’t be forced to pick up autoconfig with a starter whose responsibility is dep mgmt. Let me sleep on it😁 |
@ThomasVitale, |
- Split spring-ai-spring-boot-autoconfigure into modules - This PR addresses the restructuring of the following spring boot autoconfigurations: - spring-ai retry -> common - spring-ai chat client/model/memory -> chat - spring-ai chat/embedding/image observation -> observation - spring-ai chat/embedding models -> models - Update the Spring AI BOM and boot starters with the new autoconfigure modules Signed-off-by: Ilayaperumal Gopinathan <[email protected]>
9895b6d
to
b73b93a
Compare
Thanks for the explanation! That makes sense! I was more thinking about the "leaf" auto config (like "weaviate"), but I see that also in that case, if it ever needed to be composed into something else, having it inside the starter would be a limitation. |
Split spring-ai-spring-boot-autoconfigure into modules
This PR addresses the restructuring of the following spring boot autoconfigurations:
Update the Spring AI BOM and boot starters with the new autoconfigure modules